feat: Resolve available, non-secret environment variables during compile#2118
Merged
Conversation
ferenc-csaky
force-pushed
the
feat/secret-env-var-resolve
branch
from
efff74b to
32b7477
Compare
ferenc-csaky
force-pushed
the
feat/secret-env-var-resolve
branch
from
32b7477 to
6e41c4c
Compare
ferenc-csaky
force-pushed
the
feat/secret-env-var-resolve
branch
from
d4917b6 to
035719e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2118 +/- ##
============================================
+ Coverage 13.92% 14.04% +0.11%
- Complexity 854 864 +10
============================================
Files 604 606 +2
Lines 17252 17348 +96
Branches 2086 2103 +17
============================================
+ Hits 2403 2436 +33
- Misses 14617 14677 +60
- Partials 232 235 +3 ☔ View full report in Codecov by Harness. |
ferenc-csaky
force-pushed
the
feat/secret-env-var-resolve
branch
from
035719e to
450a7b4
Compare
mbroecheler
approved these changes
Jun 9, 2026
mbroecheler
left a comment
mbroecheler
left a comment
Contributor
There was a problem hiding this comment.
The structure and setup make sense to me. Nicely done!
Do we have test coverage that an env var which is not available at compile time is left in place?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes
SecretEnvVarResolverthat will resolve available regular env var definitions, and defines a new secret env var template${{...}}that will be resolved to${...}in `compilecompileenv var resolution is applied forCREATE TABLEstatementsconnectorskey in any user-providedpackage.jsonMore detailed behavior explanation is added to the docs.
TODO